PR: Remove QHeaderView patch related files#334
Conversation
ccordoba12
left a comment
There was a problem hiding this comment.
Looks good to me, thanks @dalthviz!
|
Do you have any comment @CAM-Gerlach ? |
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM, sorry for the delay @dalthviz —I was taking a short break from GitHub for a few days to focus on other things, and then got overwhelmed when I came back
|
Looks like the tests started segfaulting on PyQt6 + Windows on both Py3.7 and 3.10 (no conda). Based on the check logs, it seems likely this is due to the PyQt PyPI wheels for Qt 6.3.0 being released; any idea on fixing this from our end, or should we pin to qt 6.2.x for now? |
Maybe it make sense to open a new issue for that and check if we can fix it for 2.1.0 (hopefully preventing the segfault even when using Qt 6.3.0 instead of just constraining to install Qt 6.2.x) Will open a new issue with your comment and start checking if I can do something about it 👍 |
|
Thanks @dalthviz ! |
Fixes #332