Skip to content

PR: Add missing QWebEngineScript support for PyQt5/6 and PySide2/6#326

Merged
dalthviz merged 2 commits intospyder-ide:masterfrom
EasyIsrael:add-qwebenginescript
Mar 2, 2022
Merged

PR: Add missing QWebEngineScript support for PyQt5/6 and PySide2/6#326
dalthviz merged 2 commits intospyder-ide:masterfrom
EasyIsrael:add-qwebenginescript

Conversation

@EasyIsrael
Copy link
Copy Markdown
Contributor

No description provided.

@CAM-Gerlach
Copy link
Copy Markdown
Member

Followup to #322

Copy link
Copy Markdown
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @EasyIsrael /

@dalthviz ?

@dalthviz dalthviz changed the title Add missing QWebEngineScript import for PyQt5 and PySide2 PR: Add missing QWebEngineScript support for PyQt5/6 and PySide2/6 Mar 2, 2022
Copy link
Copy Markdown
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @EasyIsrael ! LGTM 👍

@dalthviz dalthviz merged commit 3631565 into spyder-ide:master Mar 2, 2022
@EasyIsrael EasyIsrael deleted the add-qwebenginescript branch March 2, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants