PR: Add missing tests for aliased methods by dalthviz · Pull Request #317 · spyder-ide/qtpy

dalthviz · 2022-01-20T17:32:50Z

Fixes #316

New tests for:

CAM-Gerlach · 2022-01-24T23:29:01Z

Seems like just a few random Qt segfaults on a few specific tests on a couple platforms...

…Lite on Windows

kumattau · 2022-01-26T15:20:54Z

hi, @dalthviz

Thank you for testing.

I think subclass tests are needed to check that the original problem is fixed.

#305 (comment)

This leads to an error if I call exec_ in a QDialog subclass, at least with PyQt6
exec(self): first argument of unbound method must have type 'QDialog'

…hon 3.6

CAM-Gerlach

Thanks @dalthviz ! I had a few comments/suggestions, mostly substantive ones as opposed to nitpicks.

.github/workflows/test.sh

qtpy/tests/test_qtsql.py

setup.cfg

qtpy/tests/test_qtsql.py

qtpy/tests/test_qtgui.py

qtpy/tests/test_qtwidgets.py

* Change skip constrains definition (`os.name` vs `sys.platform`) * `pytest` version constraints * Syntaxis to select `pytest-qt` version to install on the CIs Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

CAM-Gerlach

One minor comment, otherwise LGTM! Thanks @dalthviz !

qtpy/tests/test_qtgui.py

qtpy/tests/test_qtwidgets.py

ccordoba12

This looks pretty good to me, thanks @dalthviz!

Apart from the small formatting nitpicks I left for you, I also suggest to do a small refactoring to simplify the skip conditions you added to several tests here.

qtpy/tests/test_qtcore.py

qtpy/tests/test_qtgui.py

qtpy/tests/test_qtprintsupport.py

qtpy/tests/test_qtsql.py

qtpy/tests/test_qtwidgets.py

* Improve test files docstrings and add blank lines at the end of files * Use `Path.exists` instead of `os.path.exists` Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

qtpy/tests/utils.py

ccordoba12

Last style suggestions for you @dalthviz, then this should be ready.

qtpy/tests/test_qtcore.py

qtpy/tests/test_qtgui.py

qtpy/tests/test_qtprintsupport.py

qtpy/tests/test_qtwidgets.py

CAM-Gerlach

Fix a few syntax errors in @ccordoba12 's suggestions; otherwise looks good. Thanks @dalthviz !

qtpy/tests/test_qtprintsupport.py

qtpy/tests/test_qtwidgets.py

* Improve skip statements code style Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

…rror with the dataclasses module when building wheel

ccordoba12

Great work, thanks @dalthviz!

CAM-Gerlach

LGTM, thanks @dalthviz !

dalthviz added the type:Task label Jan 20, 2022

dalthviz added this to the v2.0.1 milestone Jan 20, 2022

dalthviz self-assigned this Jan 20, 2022

dalthviz force-pushed the fixes_issue_316 branch 3 times, most recently from 96b71f5 to 5056678 Compare January 24, 2022 18:56

dalthviz force-pushed the fixes_issue_316 branch from 5056678 to 2cdecf9 Compare January 25, 2022 14:19

QtCore/QtGui: Add testing for aliased methods

13718ad

dalthviz force-pushed the fixes_issue_316 branch from 2cdecf9 to 13718ad Compare January 25, 2022 14:30

QtPrintSupport: Add tests for aliased methods

16dd533

dalthviz force-pushed the fixes_issue_316 branch from b04af5d to 16dd533 Compare January 25, 2022 15:44

QtSql: Add tests for aliased methods

2658e3f

dalthviz force-pushed the fixes_issue_316 branch from 237c80d to 3ff71b5 Compare January 25, 2022 17:06

dalthviz changed the title ~~[WIP] PR: Add missing tests for aliased methods~~ PR: Add missing tests for aliased methods Jan 25, 2022

QtWidgets: Add tests for aliased methods

8152e44

dalthviz force-pushed the fixes_issue_316 branch 2 times, most recently from f05fb0e to 327f52d Compare January 25, 2022 18:32

QtWidgets/QtSql: Fix/Skip some tests regarding using a printer and SQ…

51f46b8

…Lite on Windows

dalthviz force-pushed the fixes_issue_316 branch from 327f52d to 51f46b8 Compare January 26, 2022 14:53

dalthviz marked this pull request as ready for review January 26, 2022 14:53

QtWidgets: Skip stalled test for QDialog and QMenu on MacOS/conda/Pyt…

5159f4c

…hon 3.6

dalthviz force-pushed the fixes_issue_316 branch 2 times, most recently from 351955b to 0ef6f10 Compare January 26, 2022 16:26

QtWidgets: Add test for QDialog subclass. Remove qtbot.addWidget calls

d69796d

dalthviz force-pushed the fixes_issue_316 branch from 0ef6f10 to d69796d Compare January 26, 2022 16:41

dalthviz requested review from CAM-Gerlach and ccordoba12 January 26, 2022 16:41

CAM-Gerlach requested changes Jan 27, 2022

View reviewed changes

Testing: Apply suggestions from code review

49c0dbd

* Change skip constrains definition (`os.name` vs `sys.platform`) * `pytest` version constraints * Syntaxis to select `pytest-qt` version to install on the CIs Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

dalthviz force-pushed the fixes_issue_316 branch 3 times, most recently from 8e3f052 to 4b9c2ca Compare January 27, 2022 18:11

Testing: Fix test.sh on macOS and add fixtures

aa01584

dalthviz force-pushed the fixes_issue_316 branch from 4d668bc to aa01584 Compare January 27, 2022 18:53

dalthviz requested a review from CAM-Gerlach January 27, 2022 18:53

CAM-Gerlach approved these changes Jan 27, 2022

View reviewed changes

qtpy/tests/test_qtgui.py Outdated Show resolved Hide resolved

qtpy/tests/test_qtwidgets.py Outdated Show resolved Hide resolved

qtpy/tests/test_qtwidgets.py Outdated Show resolved Hide resolved

ccordoba12 reviewed Jan 28, 2022

View reviewed changes

dalthviz and others added 2 commits January 28, 2022 10:18

Testing: Apply suggestions from code review

2e4d7dd

* Improve test files docstrings and add blank lines at the end of files * Use `Path.exists` instead of `os.path.exists` Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

Testing: Create utils module for USE_CONDA validations

348710c

dalthviz requested review from CAM-Gerlach and ccordoba12 January 28, 2022 16:10

ccordoba12 reviewed Jan 28, 2022

View reviewed changes

qtpy/tests/utils.py Show resolved Hide resolved

qtpy/tests/utils.py Show resolved Hide resolved

ccordoba12 reviewed Jan 29, 2022

View reviewed changes

CAM-Gerlach reviewed Jan 29, 2022

View reviewed changes

qtpy/tests/test_qtprintsupport.py Outdated Show resolved Hide resolved

qtpy/tests/test_qtwidgets.py Outdated Show resolved Hide resolved

qtpy/tests/test_qtwidgets.py Outdated Show resolved Hide resolved

qtpy/tests/test_qtwidgets.py Outdated Show resolved Hide resolved

Testing: Apply suggestions from code review

328f82a

* Improve skip statements code style Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com> Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>

dalthviz force-pushed the fixes_issue_316 branch 2 times, most recently from 0d8ff1a to 1edfc07 Compare January 31, 2022 16:06

Testing: Add restriction for pip version with Python 3.6 to prevent e…

4a29566

…rror with the dataclasses module when building wheel

dalthviz force-pushed the fixes_issue_316 branch from 1edfc07 to 4a29566 Compare January 31, 2022 16:24

dalthviz requested review from CAM-Gerlach and ccordoba12 January 31, 2022 16:44

ccordoba12 approved these changes Jan 31, 2022

View reviewed changes

CAM-Gerlach approved these changes Jan 31, 2022

View reviewed changes

CAM-Gerlach merged commit 6f5a08e into spyder-ide:master Jan 31, 2022

CAM-Gerlach mentioned this pull request Feb 3, 2023

QTextStreamManipulator has no exec method on PyQt5/6 #402

Closed

Uh oh!

Conversation

dalthviz commented Jan 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CAM-Gerlach commented Jan 24, 2022

Uh oh!

kumattau commented Jan 26, 2022

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccordoba12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccordoba12 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccordoba12 left a comment

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dalthviz commented Jan 20, 2022 •

edited

Loading