PR: Map exec_ to their non-deprecated alternatives#287
Merged
dalthviz merged 1 commit intospyder-ide:masterfrom Nov 26, 2021
Merged
PR: Map exec_ to their non-deprecated alternatives#287dalthviz merged 1 commit intospyder-ide:masterfrom
dalthviz merged 1 commit intospyder-ide:masterfrom
Conversation
Member
|
Thanks @kumattau ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #286.
All
exec_s of PySide6 are simply mapped (assigned) toexecs to avoid the following DeprecationWarning of PySide6.I think if there is no problem if
exec_is overwritten, this PR can be merged.If a way to access the original
exec_is required, QtPy needs to provide the option for controlling the overwrite or the special attribute for accessing originalexec_.