This repository was archived by the owner on Feb 23, 2023. It is now read-only.
Spring Aot Maven Plugin does not work with Maven Compiler Plugin > 3.8.1#1559
Closed
mhalbritter wants to merge 1 commit intospring-attic:mainfrom
Conversation
Contributor
|
Thanks for this PR, does the AOT plugin still work with previous versions (<= 3.8.1) or not? @bclozel Could you please review the PR? |
Contributor
Author
|
Oh sorry, should have put that in the description. Yes, i tested it with 3.8.1 too, and it works. The |
snicoll
reviewed
Mar 30, 2022
Contributor
snicoll
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've added a suggestion, let me know what you think.
- Updates the maven-compiler-plugin in the samples to the latest available one, 3.10.1 - The maven-compiler-plugin starting from 3.9.0 removed the configuration option 'compilePath', which the TestGenerateMojo was using. This option was not used and have been removed by the maven-compiler-plugin team in commit 419bf040893dac8f300deb5b36daf5f487dea8d2 See spring-atticgh-1514
210cc7a to
029793d
Compare
snicoll
pushed a commit
that referenced
this pull request
Mar 31, 2022
The maven-compiler-plugin starting from 3.9.0 removed the configuration option 'compilePath', which the TestGenerateMojo was using. This option was not used and have been removed by the maven-compiler-plugin team in commit 419bf040893dac8f300deb5b36daf5f487dea8d2 See gh-1559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the maven-compiler-plugin in the samples to the latest available one, 3.10.1
The maven-compiler-plugin starting from 3.9.0 removed the configuration option 'compilePath', which the TestGenerateMojo was using. This option was not used and have been removed by the maven-compiler-plugin team in commit apache/maven-compiler-plugin@419bf04
See gh-1514