This repository was archived by the owner on Feb 23, 2023. It is now read-only.
spring-aot-test: Include test with multiple Extend or Nested#1474
Closed
GregoireW wants to merge 2 commits intospring-attic:mainfrom
Closed
spring-aot-test: Include test with multiple Extend or Nested#1474GregoireW wants to merge 2 commits intospring-attic:mainfrom
GregoireW wants to merge 2 commits intospring-attic:mainfrom
Conversation
Signed-off-by: GregoireW <24318548+GregoireW@users.noreply.github.com>
Signed-off-by: GregoireW <24318548+GregoireW@users.noreply.github.com>
Contributor
|
@bclozel Can I merge this PR from you POV? |
Contributor
|
I've just merged this PR, reducing its scope to repeated |
Contributor
Author
|
Arrrrgggg... Why not nested tests ?
Do you plan to add this later? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tend to fix #1427
Sometime, test can have multiple
@ExtendWith, for instance if you useTestContaineror simply use@ExtendWith(OutputCaptureExtension.class). The current version crash because such test are not picked up correctly.Also, if you have
@Nestedtest, those nested test are not picked up correctly and again, it result in a test failure.This PR tend to fix that : Checking every value of
@ExtendWithannotation and adding nested class if the enclosing class is a Spring test class.Signed-off-by: GregoireW 24318548+GregoireW@users.noreply.github.com