Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Sort the factories in "spring.factories"#1424

Closed
ttddyy wants to merge 1 commit intospring-attic:mainfrom
ttddyy:sort-factories
Closed

Sort the factories in "spring.factories"#1424
ttddyy wants to merge 1 commit intospring-attic:mainfrom
ttddyy:sort-factories

Conversation

@ttddyy
Copy link
Contributor

@ttddyy ttddyy commented Jan 5, 2022

In the Spring Framework, SpringFactoriesLoader returns sorted factories(by @Order and Ordered).

This PR applies the same ordering algorithm to the SpringFactory instances; so that, the generated StaticSpringFactories holds the proper orderings.

@ttddyy
Sort the factories in "spring.factories"
10e59db 
The Spring Framework considers the `@Order` and `Ordered` in factory classes in
`spring.factories`.

This commit applies the same ordering algorithm to the `SpringFactory`
instances; so that, the generated `StaticSpringFactories` holds the proper
orderings.

Signed-off-by: Tadaya Tsuyukubo <tadaya@ttddyy.net>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 5, 2022
@sdeleuze sdeleuze requested a review from bclozel January 6, 2022 08:09
@bclozel bclozel added this to the 0.11.2 milestone Jan 11, 2022
@bclozel bclozel added theme: aot type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 11, 2022
@bclozel bclozel closed this in 4952173 Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bclozel bclozel Awaiting requested review from bclozel

Assignees

No one assigned

Labels

type: enhancement A general enhancement

Milestone

0.11.2

Development

Successfully merging this pull request may close these issues.

3 participants

@ttddyy @bclozel @spring-projects-issues