Skip to content

Add Number Input (validation)#849

Closed
Nico-DF wants to merge 2 commits intospring-projects:mainfrom
Nico-DF:feature/input-number
Closed

Add Number Input (validation)#849
Nico-DF wants to merge 2 commits intospring-projects:mainfrom
Nico-DF:feature/input-number

Conversation

@Nico-DF
Copy link
Copy Markdown
Contributor

@Nico-DF Nico-DF commented Aug 7, 2023

Adding a new type of input: NumberInput

It defaults to Integer and is basically a StringInput with a validation (similar to ConfirmInput)

  • You can specify any number class
  • Accept any format recognized by java from string (.5; 1.6e-3;...)
  • Can be required (non-null)

component-number-input-1

component-flow-showcase-1

image

@Nico-DF Nico-DF force-pushed the feature/input-number branch from bbfcee4 to c98d203 Compare August 7, 2023 12:03
@kieronedwards
Copy link
Copy Markdown

kieronedwards commented May 2, 2024 •
edited
Loading

@jvalkeal this looks like a good addition - any reason why it has not been merged ? Or is there a way we can add custom input handlers

huyuanxin
huyuanxin approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown

@huyuanxin huyuanxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, could you please merge this pr? @jvalkeal

@fmbenhassine
Copy link
Copy Markdown
Contributor

fmbenhassine commented Apr 25, 2025

This is a nice addition indeed! I will plan it for the next major release 4.0.

Can you please update and rebase the PR on the latest main first? I will take a look in more details once updated.

Thank you upfront.

@fmbenhassine fmbenhassine added status/need-feedback Calling participant to provide feedback type/feature Is a feature request area/components Belongs ui components labels Apr 25, 2025
@fmbenhassine fmbenhassine added this to the 4.0.0 milestone Apr 25, 2025
@Nico-DF Nico-DF force-pushed the feature/input-number branch from 24f267a to fc1febf Compare April 25, 2025 13:29
@Nico-DF Nico-DF changed the base branch from 2.1.x to main April 25, 2025 13:29
@Nico-DF Nico-DF force-pushed the feature/input-number branch 3 times, most recently from cf89d78 to ce584d3 Compare April 25, 2025 13:41
@Nico-DF
Copy link
Copy Markdown
Contributor Author

Nico-DF commented Apr 25, 2025

This is a nice addition indeed! I will plan it for the next major release 4.0.

Can you please update and rebase the PR on the latest main first? I will take a look in more details once updated.

Thank you upfront.

Updated, but I couldn't rengenerate properly antora nor regenerate some asciinema (no WSL/linux at disposal), so did the best I can rn

@fmbenhassine
Copy link
Copy Markdown
Contributor

fmbenhassine commented Apr 25, 2025

No problem, I will take care of that.

Thank you for the updates! I will check in details once we start working on v4.

@fmbenhassine fmbenhassine removed the status/need-feedback Calling participant to provide feedback label Oct 30, 2025
@fmbenhassine fmbenhassine mentioned this pull request Oct 31, 2025
Closed
@fmbenhassine
Copy link
Copy Markdown
Contributor

fmbenhassine commented Nov 27, 2025

Hi @Nico-DF

I think we can proceed and merge this PR now. Can you please rebase it on the latest main?

Please exclude the changes in samples, they are outdated.

Thank you upfront.

@Nico-DF
feat: adding number input type
6a5139f 
Signed-off-by: Nicola Di Falco <difalco.nicola@gmail.com>
@Nico-DF
feat: adding documentation
50691a8 
Signed-off-by: Nicola Di Falco <difalco.nicola@gmail.com>
@Nico-DF Nico-DF force-pushed the feature/input-number branch from ce584d3 to 50691a8 Compare November 27, 2025 15:41
@Nico-DF
Copy link
Copy Markdown
Contributor Author

Nico-DF commented Nov 27, 2025

Aaand also done. I'll check if there is any issue more likely tomorrow

@fmbenhassine
Copy link
Copy Markdown
Contributor

fmbenhassine commented Nov 28, 2025

Thank you for the updates! Rebased and merged. Thank you for your contribution 👍

@fmbenhassine fmbenhassine modified the milestones: 4.0.0, 4.0.0-M2 Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@huyuanxin huyuanxin huyuanxin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/components Belongs ui components type/feature Is a feature request

Projects

None yet

Milestone

4.0.0-M2

Development

Successfully merging this pull request may close these issues.

4 participants

@Nico-DF @kieronedwards @fmbenhassine @huyuanxin