Enable AuthenticationManager configuration in saml2Login#7693
Merged
fhanik merged 2 commits intospring-projects:masterfrom Dec 17, 2019
Merged
Enable AuthenticationManager configuration in saml2Login#7693fhanik merged 2 commits intospring-projects:masterfrom
fhanik merged 2 commits intospring-projects:masterfrom
Conversation
jzheaux
requested changes
Dec 2, 2019
...ingframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurerTests.java
Outdated
Show resolved
Hide resolved
...ramework/security/saml2/provider/service/servlet/filter/Saml2WebSsoAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Outdated
Show resolved
Hide resolved
...ramework/security/saml2/provider/service/servlet/filter/Saml2WebSsoAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
...ramework/security/saml2/provider/service/servlet/filter/Saml2WebSsoAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
jgrandja
requested changes
Dec 4, 2019
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Outdated
Show resolved
Hide resolved
...ingframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurerTests.java
Outdated
Show resolved
Hide resolved
...ramework/security/config/annotation/web/configurers/saml2/TestRelyingPartyRegistrations.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/config/annotation/web/configurers/saml2/TestSaml2Credentials.java
Outdated
Show resolved
Hide resolved
jzheaux
reviewed
Dec 4, 2019
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Dec 6, 2019
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Outdated
Show resolved
Hide resolved
...framework/security/saml2/provider/service/authentication/OpenSamlAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/config/annotation/web/configurers/saml2/TestSaml2Credentials.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Dec 13, 2019
Contributor
jzheaux
left a comment
There was a problem hiding this comment.
Looking good, sir. I've left some additional feedback inline.
...ingframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurerTests.java
Outdated
Show resolved
Hide resolved
docs/manual/src/docs/asciidoc/_includes/servlet/saml2/saml2-login.adoc
Outdated
Show resolved
Hide resolved
docs/manual/src/docs/asciidoc/_includes/servlet/saml2/saml2-login.adoc
Outdated
Show resolved
Hide resolved
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Outdated
Show resolved
Hide resolved
jzheaux
approved these changes
Dec 17, 2019
AbstractAuthenticationProcessingFilter.setRequiresAuthenticationRequestMatcher is public and final, so there is a risk that the underlying matcher can become different if one is not careful.
bdefb66 to
bbf200f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow configuration of AuthenticationManagerResolver in saml2Login()
Fixes gh-7654