Skip to content

Close Nimbus Information Leak#5459

Merged
rwinch merged 1 commit intospring-projects:masterfrom
jzheaux:gh-5457
Jul 3, 2018
Merged

Close Nimbus Information Leak#5459
rwinch merged 1 commit intospring-projects:masterfrom
jzheaux:gh-5457

Conversation

@jzheaux
Copy link
Copy Markdown
Contributor

@jzheaux jzheaux commented Jun 25, 2018

This commit captures and remaps the exception that Nimbus throws
when a PlainJWT is presented to it.

While the surrounding classes are likely only used today by the
oauth2Login flow, since they are public, we'll patch them at this
point for anyone who may be using them directly.

Fixes: gh-5457

@jzheaux
Copy link
Copy Markdown
Contributor Author

jzheaux commented Jun 25, 2018

Related to jzheaux#5

@jzheaux jzheaux force-pushed the gh-5457 branch 3 times, most recently from c6e29f5 to 71f4893 Compare June 28, 2018 17:15
This commit captures and remaps the exception that Nimbus throws
when a PlainJWT is presented to it.

While the surrounding classes are likely only used today by the
oauth2Login flow, since they are public, we'll patch them at this
point for anyone who may be using them directly.

Fixes: spring-projectsgh-5457
@rwinch rwinch self-assigned this Jul 3, 2018
@rwinch rwinch added type: enhancement A general enhancement JWT-JOSE labels Jul 3, 2018
@rwinch rwinch added this to the 5.1.0.M2 milestone Jul 3, 2018
@rwinch rwinch merged commit 998d1a0 into spring-projects:master Jul 3, 2018
@rwinch
Copy link
Copy Markdown
Member

rwinch commented Jul 3, 2018

Thanks for the PR! This is now merged into master

@jzheaux
Copy link
Copy Markdown
Contributor Author

jzheaux commented Jul 3, 2018

Thanks, @rwinch

@rwinch rwinch added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Submitting alg=none should not discuss class

2 participants