Skip to content

Fail on javadoc warnings for spring-security-aspects#18855

Merged
rwinch merged 1 commit intospring-projects:mainfrom
DDINGJOO:gh-18446
Mar 9, 2026
Merged

Fail on javadoc warnings for spring-security-aspects#18855
rwinch merged 1 commit intospring-projects:mainfrom
DDINGJOO:gh-18446

Conversation

@DDINGJOO
Copy link
Copy Markdown
Contributor

@DDINGJOO DDINGJOO commented Mar 6, 2026

This PR addresses gh-18446.

Summary:

  • apply javadoc-warnings-error to spring-security-aspects

Context:

  • :spring-security-aspects:javadoc currently reports NO-SOURCE because this module contains AspectJ (.aj) sources and no Java sources for the javadoc task.
  • This change keeps behavior unchanged today and aligns the module with the javadoc warnings policy used by other modules.

Verification:

  • JAVA_HOME= ./gradlew --no-build-cache clean :spring-security-aspects:javadoc :spring-security-aspects:check
  • Result: BUILD SUCCESSFUL, and :spring-security-aspects:javadoc remains NO-SOURCE

Closes gh-18446

@DDINGJOO
Apply javadoc warnings plugin to aspects
a7f8c42 
The aspects module currently runs :javadoc as NO-SOURCE because it only contains AspectJ sources. Apply javadoc-warnings-error for consistency with other modules and future Java sources.

Closes spring-projectsgh-18446

Signed-off-by: ddingjoo <ddingsha9@teambind.co.kr>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 6, 2026
@rwinch rwinch changed the title Apply javadoc warnings plugin to aspects Fail on javadoc warnings for spring-security-aspects Mar 9, 2026
@rwinch rwinch self-assigned this Mar 9, 2026
@rwinch rwinch added in: build An issue in the build in: docs An issue in Documentation or samples type: enhancement A general enhancement labels Mar 9, 2026
@rwinch rwinch added this to the 7.1.0-M3 milestone Mar 9, 2026
@rwinch rwinch enabled auto-merge (rebase) March 9, 2026 20:04
@rwinch
Copy link
Copy Markdown
Member

rwinch commented Mar 9, 2026

Thanks for the PR! This will be merged into main as soon as the build passes

@rwinch rwinch merged commit 612f788 into spring-projects:main Mar 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rwinch rwinch

Labels

in: build An issue in the build in: docs An issue in Documentation or samples status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Projects

None yet

Milestone

7.1.0-M3

Development

Successfully merging this pull request may close these issues.

Remove javadoc warnings for spring-security-aspects

3 participants

@DDINGJOO @rwinch @spring-projects-issues