Add Missing OnCommitedResponseWrapper Header Overrides#18798
Merged
rwinch merged 1 commit intospring-projects:6.5.xfrom Feb 25, 2026
Merged
Conversation
Spring Security's `OnCommitedResponseWrapper` does not override the `setHeader`, `setIntHeader`, `addIntHeader` methods. This means that if the `Content-Length` response header is specified using any of those methods then the response body length is not tracked and can be committed before the response headers are written. Spring Security should override the missing methods and track `Content-Length` as is already done for `addHeader`. This issue is the underlying problem for spring-projects/spring-framework#36381 Closes spring-projectsgh-18797
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring Security's
OnCommitedResponseWrapperdoes not override thesetHeader,setIntHeader,addIntHeadermethods. This means that if the
Content-Lengthresponse header is specified using any of those methods thenthe response body length is not tracked and can be committed before the response headers are written.
Spring Security should override the missing methods and track
Content-Lengthas is already done foraddHeader.This issue is the underlying problem for spring-projects/spring-framework#36381
Closes gh-18797