Skip to content

Restore upgradeEncoding condition in DaoAuthenticationProvider#18788

Merged
jzheaux merged 1 commit intospring-projects:7.0.xfrom
therepanic:gh-18781
Mar 4, 2026
Merged

Restore upgradeEncoding condition in DaoAuthenticationProvider#18788
jzheaux merged 1 commit intospring-projects:7.0.xfrom
therepanic:gh-18781

Conversation

@therepanic
Copy link
Copy Markdown
Contributor

After adding jspecify support in the module that contains the DaoAuthenticationProvider class, we actually changed the contract logic, which is a good thing, and this commit fixes it.

Closes: gh-18781

After adding jspecify support in the module that contains the
DaoAuthenticationProvider class, we actually changed the contract logic,
which is a good thing, and this commit fixes it.

Closes: spring-projectsgh-18781

Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
@jzheaux jzheaux changed the base branch from main to 7.0.x March 4, 2026 00:58
@jzheaux jzheaux changed the title Refine upgradeEncoding condition in DaoAuthenticationProvider Restore upgradeEncoding condition in DaoAuthenticationProvider Mar 4, 2026
@jzheaux jzheaux added in: core An issue in spring-security-core type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 4, 2026
@jzheaux jzheaux added this to the 7.0.4 milestone Mar 4, 2026
@jzheaux jzheaux merged commit 4f97217 into spring-projects:7.0.x Mar 4, 2026
7 checks passed
@jzheaux
Copy link
Copy Markdown
Contributor

jzheaux commented Mar 4, 2026

Thanks for the PR, @therepanic! I rebased your PR to 7.0.x and then also forward-ported it to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core An issue in spring-security-core type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: Improve logic rigor for upgradeEncoding in DaoAuthenticationProvider.createSuccessAuthentication

3 participants