Add missing AOT Runtime Hints#18767
Conversation
Signed-off-by: Josh Long <54473+joshlong@users.noreply.github.com>
- Saml2RuntimeHints consistently uses String in separate method for to ensure no classpath issues - Fix Whitespace/Checkstyle - Add Missing Nullability Annotations
|
@joshlong Thanks for the PR. I've pushed fixes to the PR for your review. Most of it was cosmetic, but it would be worth you double checking that I didn't break anything. In particular, I'd appreciate that you review that I didn't break anything by updating
I'm also interested in how you found these problems. Is there a way we can add meaningful tests (vs just mocks)? |
|
After the issue with GraalVM and SAA I realized there were probably others so I started looking for things that eventually landed in the session. Then did reflection. Then I realized I was out of my depth in such a large codebase so I started using an AI to help me find the cases. Then I challenged it on every thing it gave me back and asked it to defend its choices, a lot of which were bad. What u see is what's defensible. I'd think ur changes are fine but will have to look at it in depth later |
|
yah changes look fine |
Uh oh!
There was an error while loading. Please reload this page.