Skip to content

Add missing AOT Runtime Hints#18767

Merged
rwinch merged 2 commits intospring-projects:mainfrom
joshlong:aotv1
Feb 20, 2026
Merged

Add missing AOT Runtime Hints#18767
rwinch merged 2 commits intospring-projects:mainfrom
joshlong:aotv1

Conversation

@joshlong
Copy link
Copy Markdown
Member

@joshlong joshlong commented Feb 19, 2026

  • AclRuntimeHints
  • Missing Authentication hints
  • KerberosRuntimeHints
  • OAuth2 r2dbc hints
  • Saml2RuntimeHints
  • PreAuthenticatedAuthenticationToken

Signed-off-by: Josh Long <54473+joshlong@users.noreply.github.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2026
@rwinch rwinch self-assigned this Feb 19, 2026
@rwinch rwinch removed the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2026
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2026
- Saml2RuntimeHints consistently uses String in separate method for
  to ensure no classpath issues
- Fix Whitespace/Checkstyle
- Add Missing Nullability Annotations
@rwinch rwinch added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 19, 2026
@rwinch
Copy link
Copy Markdown
Member

rwinch commented Feb 19, 2026

@joshlong Thanks for the PR. I've pushed fixes to the PR for your review. Most of it was cosmetic, but it would be worth you double checking that I didn't break anything. In particular, I'd appreciate that you review that I didn't break anything by updating Saml2RuntimeHints to move the inlined hints into the register methods:

I'm also interested in how you found these problems. Is there a way we can add meaningful tests (vs just mocks)?

@rwinch rwinch changed the title aot improvements Add missing AOT Runtime Hints Feb 19, 2026
@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue labels Feb 19, 2026
@joshlong
Copy link
Copy Markdown
Member Author

After the issue with GraalVM and SAA I realized there were probably others so I started looking for things that eventually landed in the session. Then did reflection. Then I realized I was out of my depth in such a large codebase so I started using an AI to help me find the cases. Then I challenged it on every thing it gave me back and asked it to defend its choices, a lot of which were bad. What u see is what's defensible.

I'd think ur changes are fine but will have to look at it in depth later

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 19, 2026
@joshlong
Copy link
Copy Markdown
Member Author

yah changes look fine

@rwinch rwinch removed the status: feedback-provided Feedback has been provided label Feb 20, 2026
@rwinch rwinch added this to the 7.1.0-M3 milestone Feb 20, 2026
@rwinch rwinch merged commit 21978ca into spring-projects:main Feb 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: core An issue in spring-security-core type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants