Specify charset in WWW-Authenticate for Basic Auth#18760
Merged
jzheaux merged 2 commits intospring-projects:mainfrom Mar 10, 2026
Merged
Specify charset in WWW-Authenticate for Basic Auth#18760jzheaux merged 2 commits intospring-projects:mainfrom
WWW-Authenticate for Basic Auth#18760jzheaux merged 2 commits intospring-projects:mainfrom
Conversation
therepanic
commented
Feb 18, 2026
...main/java/org/springframework/security/web/authentication/www/BasicAuthenticationFilter.java
Show resolved
Hide resolved
therepanic
commented
Feb 18, 2026
.../java/org/springframework/security/web/authentication/www/BasicAuthenticationEntryPoint.java
Outdated
Show resolved
Hide resolved
therepanic
commented
Feb 18, 2026
.../org/springframework/security/web/authentication/www/BasicAuthenticationEntryPointTests.java
Show resolved
Hide resolved
fc49059 to
e932168
Compare
Contributor
Author
|
It turned out that some tests also required modifications and the addition of a charset. I wrote about this here: #18760 (comment) and here: #18760 (comment). And over time, I'm starting to think that maybe the tests should still pass in this case? Then we'll have to create some kind of toggle switch, so we can enable charset additions. I'd like to know the best way to do this to fit the project. I'm not sure what's best. |
jzheaux
requested changes
Feb 26, 2026
Contributor
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @therepanic! I've left my feedback inline.
...main/java/org/springframework/security/web/authentication/www/BasicAuthenticationFilter.java
Show resolved
Hide resolved
.../java/org/springframework/security/web/authentication/www/BasicAuthenticationEntryPoint.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/security/web/authentication/www/BasicAuthenticationEntryPoint.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/security/web/authentication/www/BasicAuthenticationEntryPoint.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for review. I followed your suggestions and pushed the change. I agree with your suggestions and followed them, pushing the change. |
jzheaux
requested changes
Mar 3, 2026
Contributor
jzheaux
left a comment
There was a problem hiding this comment.
Thanks for the updates, @therepanic. I've left just a little more feedback.
.../java/org/springframework/security/web/authentication/www/BasicAuthenticationEntryPoint.java
Show resolved
Hide resolved
.../java/org/springframework/security/web/authentication/www/BasicAuthenticationEntryPoint.java
Outdated
Show resolved
Hide resolved
.../org/springframework/security/web/authentication/www/BasicAuthenticationEntryPointTests.java
Show resolved
Hide resolved
In this commit, we add support for the charset from RFC-7617, which definitely solves the problem when the client does not know what charset we are parsing with. Closes: spring-projectsgh-18755 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
Contributor
|
Thanks for the updates, @therepanic! I've also polished the documentation a bit, including mentioning this in |
jzheaux
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we add support for the charset from RFC-7617, which definitely solves the problem when the client does not know what charset we are parsing with.
Closes: gh-18755