Change ActiveDirectoryLdapAuthenticationProvider to use LdapClient#18627
Merged
jzheaux merged 1 commit intospring-projects:mainfrom Mar 2, 2026
Merged
Change ActiveDirectoryLdapAuthenticationProvider to use LdapClient#18627jzheaux merged 1 commit intospring-projects:mainfrom
ActiveDirectoryLdapAuthenticationProvider to use LdapClient#18627jzheaux merged 1 commit intospring-projects:mainfrom
Conversation
therepanic
commented
Feb 1, 2026
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Show resolved
Hide resolved
therepanic
commented
Feb 1, 2026
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Show resolved
Hide resolved
therepanic
commented
Feb 1, 2026
...ramework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProviderTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I don't quite understand whether this is breaking Change or not, please take a look at #18627 (comment) |
Member
|
FYI I rebased based off origin/main |
jzheaux
requested changes
Feb 25, 2026
Contributor
jzheaux
left a comment
There was a problem hiding this comment.
Thanks for the PR, @therepanic! I've left some feedback inline.
...ramework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProviderTests.java
Outdated
Show resolved
Hide resolved
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Show resolved
Hide resolved
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Show resolved
Hide resolved
...ringframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
Replaces SpringSecurityLdapTemplate with LdapClient for user search operations. Closes: spring-projectsgh-17291 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Contributor
Author
|
Thanks for the great review. I've updated the tests and made them more readable, as you described here: #18627 (comment). Regarding the null result check in #18627 (comment), I've created an issue: spring-projects/spring-ldap#1404. Whether we add this commit to the spring-ldap repository before or after the update, I'll implement the update there. |
jzheaux
approved these changes
Mar 2, 2026
Contributor
|
Thanks, @therepanic! This is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
SpringSecurityLdapTemplatewithLdapClientfor user search operations.Closes: gh-17291