Fix spring-security-oauth2-core compiler warnings#18482
Merged
rwinch merged 3 commits intospring-projects:mainfrom Jan 12, 2026
Merged
Fix spring-security-oauth2-core compiler warnings#18482rwinch merged 3 commits intospring-projects:mainfrom
rwinch merged 3 commits intospring-projects:mainfrom
Conversation
Member
eb1953b to
c6950bc
Compare
Closes: spring-projectsgh-18434 Signed-off-by: Pavel Vassiliev <paulvas@gmail.com> Signed-off-by: paulvas <paulvas@gmail.com>
To prevent future compiler warnings from being introduced, this change applies the `compile-warnings-error` plugin to the `spring-security-oauth2-core` module. This ensures that any new warnings will fail the build, maintaining code quality and preventing warning accumulation. Fixes: spring-projectsgh-18434 Signed-off-by: Pavel Vassiliev <paulvas@gmail.com> Signed-off-by: paulvas <paulvas@gmail.com>
rwinch
requested changes
Jan 12, 2026
Member
rwinch
left a comment
There was a problem hiding this comment.
Thank you. Sorry for not being clear on the requirements for the plugin. I've provided feedback inline to clarify and updated the description of the parent issue to reflect that feedback.
| import org.gradle.api.tasks.compile.JavaCompile | ||
| import org.jetbrains.kotlin.gradle.tasks.KotlinCompile | ||
|
|
||
| class CompileWarningsErrorPlugin implements Plugin<Project> { |
Member
There was a problem hiding this comment.
Thank you for adding the plugin. I see that I had a typo in the description with the file suffix being .groovy. It should have been .gradle so that you can use a Pre-compiled Script Plugin at buildSrc/src/main/groovy/javadoc-warnings-error.gradle. Can you please update this?
Fixes: spring-projectsgh-18434 Signed-off-by: paulvas <paulvas@gmail.com>
Contributor
Author
|
Thank you for the feedback Rob. I have migrated compiler-warnings-error plugin to gradle. |
Member
|
Thank you! This is now marked to be merged as soon as the checks complete successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the manual instantiation of
HttpMessageReaders withClientCodecConfigurer.create().getReaders().Closes: gh-18434