ServerHttpSecurityConfiguration should not set userDetailsPasswordService to a null value#18276
Merged
jzheaux merged 1 commit intospring-projects:7.0.xfrom Mar 9, 2026
Merged
Conversation
...gframework/security/config/annotation/web/reactive/ServerHttpSecurityConfigurationTests.java
Outdated
Show resolved
Hide resolved
...gframework/security/config/annotation/web/reactive/ServerHttpSecurityConfigurationTests.java
Outdated
Show resolved
Hide resolved
57a266d to
4218d01
Compare
jzheaux
requested changes
Mar 4, 2026
Contributor
jzheaux
left a comment
There was a problem hiding this comment.
Thanks for the PR, @sephiroth-j!
It appears this was introduced by 7c887d2 in 7.0. As such, if you are able, can you please also rebase this PR to 7.0.x? If that gets tricky, no worries, I can jump in and help.
...springframework/security/config/annotation/web/reactive/ServerHttpSecurityConfiguration.java
Show resolved
Hide resolved
This use case specifically arises when using `ReactiveUserDetailsService` without `ReactiveUserDetailsPasswordService`. Closes spring-projectsgh-17986 Signed-off-by: Ronny Perinke <23166289+sephiroth-j@users.noreply.github.com>
Contributor
Author
|
Hello @jzheaux, I noticed that you have already rebased the branch. Is there anything else that needs to be done/changed? |
Contributor
|
Hi, @sephiroth-j, no nothing more is needed, thanks for checking. This is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... when using
ReactiveUserDetailsServicewithoutReactiveUserDetailsPasswordService.The existing test uses a
MapReactiveUserDetailsServicethat implementsReactiveUserDetailsPasswordService, which does not trigger the error.fixes gh-17986