Add @Nullable to changePassword parameters in UserDetailsManager#18271
Merged
rwinch merged 1 commit intospring-projects:mainfrom Jan 23, 2026
Merged
Add @Nullable to changePassword parameters in UserDetailsManager#18271rwinch merged 1 commit intospring-projects:mainfrom
@Nullable to changePassword parameters in UserDetailsManager#18271rwinch merged 1 commit intospring-projects:mainfrom
Conversation
Closes: spring-projectsgh-18257 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Contributor
Author
|
Since there's a test that checks protected On the other hand, it might be better to delete the test, since again, the argument isn't used and it's a protected method. WDYT? |
Member
|
@therepanic Thank you for the pull request this is now merged into main 😄
I think it is good to have the test since we don't want to test based upon implementation details (that the argument isn't used) and we want to test protected methods since users can pass in values to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, an unused argument was removed from
JdbcUserDetailsManager#createNewAuthenticationthat was not used and would break the build of the current change.Closes: gh-18257