Mark targetDomainObject as @Nullable in PermissionEvaluator#18260
Merged
rwinch merged 1 commit intospring-projects:mainfrom Feb 24, 2026
Merged
Mark targetDomainObject as @Nullable in PermissionEvaluator#18260rwinch merged 1 commit intospring-projects:mainfrom
targetDomainObject as @Nullable in PermissionEvaluator#18260rwinch merged 1 commit intospring-projects:mainfrom
Conversation
Closes: spring-projectsgh-18259 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Member
|
Thanks for the Pull Request! This is now merged into main 😄 |
Member
|
This actually broke the build likely due to being rebased. I've revered the pull request changes and we will reopen the original issue. I am unable to reopen this pull request, so if you have fixes please send a new pull request. I'm sorry for the trouble here. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are other places where
PermissionEvaluatoris inherited and methods are overridden. However, these places aren't yet covered by jspecify. I expect that in the future, when these places are covered by jspecify, we'll ensure that@Nullableis used (the build simply won't pass).Closes: gh-18259