Add Support GenerateOneTimeTokenRequestResolver#16297
Merged
rwinch merged 1 commit intospring-projects:mainfrom Jan 22, 2025
Merged
Add Support GenerateOneTimeTokenRequestResolver#16297rwinch merged 1 commit intospring-projects:mainfrom
rwinch merged 1 commit intospring-projects:mainfrom
Conversation
714b2c4 to
6d330d7
Compare
rwinch
requested changes
Jan 21, 2025
Member
rwinch
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've provided feedback inline.
| * @param username username | ||
| * @param expiresIn one-time token expiration time (seconds) | ||
| */ | ||
| public GenerateOneTimeTokenRequest(String username, int expiresIn) { |
Member
There was a problem hiding this comment.
Please change expiresIn to a Duration
...ingframework/security/web/authentication/ott/DefaultGenerateOneTimeTokenRequestResolver.java
Outdated
Show resolved
Hide resolved
|
|
||
| private static final int DEFAULT_EXPIRES_IN = 300; | ||
|
|
||
| private int expiresIn = DEFAULT_EXPIRES_IN; |
Member
There was a problem hiding this comment.
Please change this to a Duration
...ingframework/security/web/authentication/ott/DefaultGenerateOneTimeTokenRequestResolver.java
Outdated
Show resolved
Hide resolved
...amework/security/config/annotation/web/configurers/ott/OneTimeTokenLoginConfigurerTests.java
Show resolved
Hide resolved
...c/main/java/org/springframework/security/authentication/ott/GenerateOneTimeTokenRequest.java
Outdated
Show resolved
Hide resolved
|
|
||
| private final String username; | ||
|
|
||
| private final int expiresIn; |
Member
There was a problem hiding this comment.
Please change this to a Duration
...c/main/java/org/springframework/security/authentication/ott/GenerateOneTimeTokenRequest.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/springframework/security/authentication/ott/GenerateOneTimeTokenRequest.java
Outdated
Show resolved
Hide resolved
6d330d7 to
dedf366
Compare
Contributor
Author
|
@rwinch thanks for feedback, all your comments have been resolved. |
rwinch
requested changes
Jan 21, 2025
Member
rwinch
left a comment
There was a problem hiding this comment.
I'm sorry I missed one more thing. Can you please document the changes and ensure to add a link in the What's New section to those changes?
a5cdaae to
0dba7d6
Compare
Closes spring-projectsgh-16291 Signed-off-by: Max Batischev <mblancer@mail.ru>
0dba7d6 to
a879f76
Compare
Contributor
Author
|
Added documentation, @rwinch done :) |
rwinch
approved these changes
Jan 22, 2025
Member
|
Thanks for the PR and your quick attention to changes! This is now merged into main 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-16291