Skip to content

Update RP-Initiated Logout target URLs#12082

Merged
jzheaux merged 1 commit into
spring-projects:5.6.xfrom
rozagerardo:gh-12081
Nov 1, 2022
Merged

Update RP-Initiated Logout target URLs#12082
jzheaux merged 1 commit into
spring-projects:5.6.xfrom
rozagerardo:gh-12081

Conversation

@rozagerardo

@rozagerardo rozagerardo commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

The URLs we're using are not actually pointing to the OIDC RP-Initiated Logout Specs.

Fixes: gh-12081

@rozagerardo rozagerardo mentioned this pull request Oct 25, 2022
Closed
@rozagerardo rozagerardo changed the title Update RP-Initiated Logout target URLs. Update RP-Initiated Logout target URLs Oct 25, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 25, 2022
@jzheaux

jzheaux commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Hi, @rozagerardo! Thanks for the PR. Will you please rebase in on the earliest branch that has the issue? We've recently moved to forward-porting fixes from the earliest supported branch, which is 5.6.x in this case.

@jzheaux jzheaux self-assigned this Oct 26, 2022
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 26, 2022
@jzheaux jzheaux added this to the 5.6.9 milestone Oct 26, 2022
@jzheaux

jzheaux commented Oct 26, 2022

Copy link
Copy Markdown
Collaborator

Also, if you run ./gradlew format, I think it will update the formatting of the JavaDoc so that the PR build passes.

@rozagerardo rozagerardo changed the base branch from main to 5.6.x October 28, 2022 02:22
@rozagerardo
Update RP-Initiated Logout target URLs.
2b264c1 
The URLs we're using are not actually pointing to the OIDC RP-Initiated Logout Specs.

Fixes: spring-projectsgh-12081
@rozagerardo

rozagerardo commented Oct 28, 2022

Copy link
Copy Markdown
Contributor Author

Sure @jzheaux , sorry about that, I missed the guidelines indicating to create the branch from the oldest maintenance branch :)

I now fixed that, re-formated the files as required, and edited the PR to point to 5.6.x 👍

Just to be clear I understood this correctly, even though we started using the links since 5.2.x, we're pointing to 5.6.x because we're currently maintaining versions from 5.6.x and above (as per the Milestones that are being actively developed) correct?

Cool, hope the PR looks good now, thanks for the patience!

@marcusdacoregio marcusdacoregio modified the milestones: 5.6.9, 5.6.10 Oct 31, 2022
@jzheaux jzheaux merged commit 8315545 into spring-projects:5.6.x Nov 1, 2022
@jzheaux

jzheaux commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Yes, @rozagerardo, that's right.

I've just merged this to 5.6.x, 5.7.x, 5.8.x, and main. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jzheaux jzheaux

Labels

in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Milestone

5.6.10

Development

Successfully merging this pull request may close these issues.

Update the RP-initiated Logout links

4 participants

@rozagerardo @jzheaux @marcusdacoregio @spring-projects-issues