Add ID to Saml2 Post and Redirect Requests#11489
Merged
jzheaux merged 2 commits intospring-projects:mainfrom Aug 2, 2022
Merged
Add ID to Saml2 Post and Redirect Requests#11489jzheaux merged 2 commits intospring-projects:mainfrom
jzheaux merged 2 commits intospring-projects:mainfrom
Conversation
7b3b17a to
bc02929
Compare
scottshidlovsky
commented
Jul 12, 2022
...ty/saml2/provider/service/web/authentication/OpenSamlAuthenticationRequestResolverTests.java
Outdated
Show resolved
Hide resolved
bc02929 to
f11e33c
Compare
jzheaux
requested changes
Jul 18, 2022
Contributor
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @scottshidlovsky! I've left some feedback inline.
...ework/security/saml2/provider/service/authentication/AbstractSaml2AuthenticationRequest.java
Outdated
Show resolved
Hide resolved
...ework/security/saml2/provider/service/authentication/AbstractSaml2AuthenticationRequest.java
Outdated
Show resolved
Hide resolved
...ework/security/saml2/provider/service/authentication/AbstractSaml2AuthenticationRequest.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/security/saml2/jackson2/Saml2PostAuthenticationRequestMixinTests.java
Outdated
Show resolved
Hide resolved
...ty/saml2/provider/service/web/authentication/OpenSamlAuthenticationRequestResolverTests.java
Outdated
Show resolved
Hide resolved
f11e33c to
2ff2467
Compare
Contributor
Author
Thank you for the review! I believe I have addressed all your feedback. |
jzheaux
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-11468