Skip to content

Use 'md:' prefix with EntityDescriptor tag in the metadata xml#11300

Merged
jzheaux merged 1 commit into
spring-projects:mainfrom
ClaudioConsolmagno:gh-11283
May 31, 2022
Merged

Use 'md:' prefix with EntityDescriptor tag in the metadata xml#11300
jzheaux merged 1 commit into
spring-projects:mainfrom
ClaudioConsolmagno:gh-11283

Conversation

@ClaudioConsolmagno

Copy link
Copy Markdown
Contributor

Create the EntityDescriptor object with EntityDescriptor.DEFAULT_ELEMENT_NAME instead of EntityDescriptor.ELEMENT_QNAME. That ensures the EntityDescriptor tag is marshalled to xml with the md: prefix, consistent with all other metadata tag elements.

I have signed the CLA.

Closes #11283

Create the EntityDescriptor object with EntityDescriptor.DEFAULT_ELEMENT_NAME instead of EntityDescriptor.ELEMENT_QNAME. That ensures the EntityDescriptor tag is marshalled to xml with the 'md:' prefix, consistent with all other metadata tags.

Closes #11283
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 29, 2022
@jzheaux jzheaux self-assigned this May 31, 2022
@jzheaux jzheaux added type: bug A general bug in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels May 31, 2022
@jzheaux jzheaux added this to the 6.0.0-M6 milestone May 31, 2022
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label May 31, 2022
@jzheaux jzheaux merged commit b470f29 into spring-projects:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should SAML metadata EntityDescriptor tag have the md: prefix?

3 participants