Skip to content

AuthoritiesAuthorizationManager.authorize throws NPE if GrantedAuthority returns null #18543

@ffray

Description

@ffray

Describe the bug
When using a complex GrantedAuthority in an Authentication and AuthoritiesAuthorizationManager.authorize is used, AuthoritiesAuthorizationManager.isAuthorized throws an NPE.

To Reproduce
Create a subclass of GrantedAuthority, whose getAuthority returns null.
Create an Authentication and add an instance of the custom class as authority.
Create an AuthoritiesAuthorizationManager and call authorize(authentication, 'SOME_VALUE').

Expected behavior
As null values are valid according to the documentation and are required in such cases,
a null-check should be introduced.

Affected version
The class is located in org.springframework.security:spring-security-core:7.0.2

Sample

See this Demo project showing the issue.
It uses Spring Boot 4.0.1 for Dependency Management.

Metadata

Metadata

Assignees

Labels

in: coreAn issue in spring-security-corestatus: duplicateA duplicate of another issuetype: bugA general bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions