Skip to content

GH-395: make the retry context aware of the policies that have a maxi…#396

Merged
artembilan merged 2 commits into
spring-projects:mainfrom
e-ivaldi:GH-395-retry-context-max-attempts-aware
Nov 17, 2023
Merged

GH-395: make the retry context aware of the policies that have a maxi…#396
artembilan merged 2 commits into
spring-projects:mainfrom
e-ivaldi:GH-395-retry-context-max-attempts-aware

Conversation

@e-ivaldi

@e-ivaldi e-ivaldi commented Oct 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@e-ivaldi e-ivaldi mentioned this pull request Oct 31, 2023
Closed
e-ivaldi
e-ivaldi commented Oct 31, 2023
View reviewed changes
Comment thread src/main/java/org/springframework/retry/support/RetryTemplate.java
e-ivaldi
e-ivaldi commented Oct 31, 2023
View reviewed changes
Comment thread src/main/java/org/springframework/retry/RetryContext.java
@artembilan artembilan added this to the 2.0.5 milestone Nov 6, 2023
artembilan
artembilan approved these changes Nov 6, 2023
View reviewed changes

@artembilan artembilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objection on this.
I like the code as it is right now in the PR without any further changes.
Thanks

@e-ivaldi

e-ivaldi commented Nov 7, 2023

Copy link
Copy Markdown
Contributor Author

I have no objection on this. I like the code as it is right now in the PR without any further changes. Thanks

Glad to hear that @artembilan, thank you

artembilan
artembilan requested changes Nov 14, 2023
View reviewed changes

@artembilan artembilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your name to the @author list of the affected classes, please.

@e-ivaldi

e-ivaldi commented Nov 17, 2023

Copy link
Copy Markdown
Contributor Author

Thanks, done. Have added myself as an author to all classes I modified that already had an author list.

@e-ivaldi e-ivaldi force-pushed the GH-395-retry-context-max-attempts-aware branch 2 times, most recently from d309296 to 37300f9 Compare November 17, 2023 18:45
artembilan
artembilan requested changes Nov 17, 2023
View reviewed changes

@artembilan artembilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a conflict in your branch against the latest main:

Conflicting files
src/test/java/org/springframework/retry/annotation/EnableRetryTests.java

Please, consider to rebase, fix it and push.

Thanks

@e-ivaldi e-ivaldi force-pushed the GH-395-retry-context-max-attempts-aware branch from 37300f9 to 5d87091 Compare November 17, 2023 18:54
@e-ivaldi

e-ivaldi commented Nov 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Oh yes, I noticed immediately after pushing the update, rebased and fixed the conflicts, thank you.

@artembilan artembilan removed this from the 2.0.5 milestone Nov 17, 2023
@artembilan artembilan merged commit 7516219 into spring-projects:main Nov 17, 2023
@artembilan

artembilan commented Nov 17, 2023

Copy link
Copy Markdown
Member

@e-ivaldi ,

thank you for contribution; looking forward for more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artembilan artembilan artembilan requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e-ivaldi @artembilan