GH-4442: Fix value serializer mappings for different classloaders#4460
Merged
Conversation
…lassloaders Fixes: spring-projects#4442 When the type mapper is initialized under one classloader and messages are produced under another (e.g. Spring DevTools restart classloader), the reverse lookup map keyed on `Class<?>` identity misses the entry because two `Class<?>` objects representing the same class loaded by different classloaders are not equal in a `HashMap` lookup. The fallback writes the FQCN header instead of the configured alias, silently breaking consumers that depend on the alias. Fix by changing the reverse map key from `Class<?>` to `String` (using `clazz.getName()`), which is classloader-agnostic. The same change is applied to the deprecated `AbstractJavaTypeMapper` for Jackson 2. Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
Contributor
Author
|
When back-porting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4442
When the type mapper is initialized under one classloader and messages are produced under another (e.g. Spring DevTools restart classloader), the reverse lookup map keyed on
Class<?>identity misses the entry because twoClass<?>objects representing the same class loaded by different classloaders are not equal in aHashMaplookup. The fallback writes the FQCN header instead of the configured alias, silently breaking consumers that depend on the alias.Fix by changing the reverse map key from
Class<?>toString(usingclazz.getName()), which is classloader-agnostic.The same change is applied to the deprecated
AbstractJavaTypeMapperfor Jackson 2.