GH-4369: Pass explicit acknowledgment mode as consumer override property#4374
GH-4369: Pass explicit acknowledgment mode as consumer override property#4374maxwell-balla wants to merge 1 commit into
Conversation
… override property Fixes spring-projects#4369 When "setExplicitShareAcknowledgment(true)" is set on the container properties, the "share.acknowledgement.mode=explicit" property is now passed to the consumer factory via a new "createShareConsumer" overload that accepts override properties, instead of relying on the user to set it manually in the factory configuration. Signed-off-by: Maxwell Balla <ballamaxwell7@gmail.com>
|
@maxwell-balla Thanks for the PR! We made some bigger refactoring and certain semantic changes in the way Share Consumers are acknowledged in 4.1. See the PR here: #4376. The gist is that |
|
Thanks for the context @sobychacko Making EXPLICIT the default in 4.1 makes a lot of sense, it's the safer behavior for most use cases. Happy to close this PR if #4376 covers it. Either way, glad the issue got attention. Also, feel free to point me to any other issues where a community contribution would help. |
|
@maxwell-balla We will let you know soon on the status of this PR. In the meantime, feel free to pick up any of these open issues slated for the |
|
@maxwell-balla Now that PR #4376 is merged upstream, we are going to close this PR since the former one addresses the fixes here. Thank you for your efforts and feedback! |
Fixes #4369
When "setExplicitShareAcknowledgment(true)" is set on the container properties, the "share.acknowledgement.mode=explicit" property is now passed to the consumer factory via a new "createShareConsumer" overload that accepts override properties, instead of relying on the user to set it manually in the factory configuration.
Signed-off-by: Maxwell Balla ballamaxwell7@gmail.com