GH-3726: Avoid ConcurrentModificationException in KafkaMessageListenerContainer#3728
Merged
Merged
Conversation
artembilan
requested changes
Jan 30, 2025
artembilan
left a comment
Member
There was a problem hiding this comment.
Please, add your name to the @author list of that changed class - and I'll merge it shortly.
Thank you!
…aMessageListenerContainer Fixes spring-projectsGH-3726 (spring-projects#3726) Signed-off-by: Tim Barabanov <t.barabanov@gmail.com>
Contributor
Author
|
Done. Thx! |
Member
|
Merged and back-ported to Thank you for contribution; looking forward for more! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes possible
ConcurrentModificationExceptioninKafkaMessageListenerContainerthat can happen in case if any ofpartitionsListenerConsumer.definedPartitionsorpartitionsListenerConsumer.assignedPartitionsfields are being iterated/modified simultaneously.For instance by consumer thread performing rebalancing and arbitrary application thread calling
getAssignedPartitionsmethod inKafkaMessageListenerContainer.To achieve desired effect I'm using synchronized wrappers. I would prefer modern concurrent collections such as
ConcurrentHashMap, butdefinedPartitionsfield has type ofLinkedHashMapand itskeySetpreserves keys order.Thus 1) no thread safe data structures available from std lib with same characteristics 2) possibly some users rely on the order. Anyway do not think that there are real life cases that can put
definedPartitionsorassignedPartitionsunder pressure.Fixes GH-3726 (#3726)