Change @RetryableTopic properties SameIntervalTopicReuseStrategy behavior to SINGLE_TOPIC#3058
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
sobychacko
requested changes
Feb 28, 2024
| * ... | ||
| * -retry-16000-224 | ||
|
|
||
| [source, java] |
Contributor
There was a problem hiding this comment.
We might want to add a short sentence stating that the following code snippet is changing the default behavior - something like If multiple topics are required, then that can be done using the following configuration.
Contributor
Author
There was a problem hiding this comment.
Thanks, fix it.
| When using a manual `AckMode` with `asyncAcks` set to true, the `DefaultErrorHandler` must be configured with `seekAfterError` set to `false`. | ||
| Starting with versions 2.9.10, 3.0.8, this will be set to true unconditionally for such configurations. | ||
| With earlier versions, it was necessary to override the `RetryConfigurationSupport.configureCustomizers()` method to set the property to `true`. | ||
| Starting with versions 2.9.10, 3.0.8, this will be set to `false` unconditionally for such configurations. |
Contributor
There was a problem hiding this comment.
Was it false in those releases?
Contributor
Author
|
|
||
| [[x32-retry-topic]] | ||
| === Change @RetryableTopic SameIntervalTopicReuseStrategy default value | ||
| Change `@RetryableTopic` property SameIntervalTopicReuseStrategy default value to SINGLE_TOPIC. |
Contributor
There was a problem hiding this comment.
Code formatting needed for SameIntervalTopicReuseStrategy and SINGLE_TOPIC.
Contributor
Author
There was a problem hiding this comment.
thanks, fix it.
* Change @RetryableTopic properties SameIntervalTopicReuseStrategy behavior to SINGLE_TOPIC. * Change unit test SameIntervalTopicReuseStrategy. * Add doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3052