Skip to content

Add async commit option to share consumer container #4324

@sobychacko

Description

@sobychacko

The container calls commitSync() unconditionally in commitAcknowledgments():

private void commitAcknowledgments() {
    try {
        this.consumer.commitSync();
    }
    catch (Exception e) {
        this.logger.error(e, "Failed to commit acknowledgments");
    }
}

ShareConsumer also has commitAsync() but it is not used. Add a ContainerProperties.setSyncShareCommits(boolean) flag (default true) so users can opt into async commits when slight ack-durability lag is acceptable.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions