-
Notifications
You must be signed in to change notification settings - Fork 322
Refine nullness checks in schema report inspection #1344
Copy link
Copy link
Closed
Labels
in: coreIssues related to config and core supportIssues related to config and core supporttype: enhancementA general enhancementA general enhancement
Milestone
Description
#1220 introduced nullness checks in the schema mapping inspection process. This generally reports all mismatches between the GraphQL schema nullness information and the corresponding Java type nullness.
We should refine this implementation with the following changes:
- if an application type is "non-null" and the GraphQL schema type is "nullable", we should not report that as a problem. Partial responses is a key GraphQL feature and we should not force developers to make fields "non-null" just because applications types are "non-null". If a data fetching error happens, the engine will null out fields in the hierarchy up until
nullis a valid value. - use "errors" instead of "mismatches" as a consequence
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
in: coreIssues related to config and core supportIssues related to config and core supporttype: enhancementA general enhancementA general enhancement