Skip to content

Support SameSite cookie attribute in MockMvcHttpConnector#30264

Closed
justin-tay wants to merge 1 commit intospring-projects:mainfrom
justin-tay:mockmvchttpconnector-samesite
Closed

Support SameSite cookie attribute in MockMvcHttpConnector#30264
justin-tay wants to merge 1 commit intospring-projects:mainfrom
justin-tay:mockmvchttpconnector-samesite

Conversation

@justin-tay
Copy link
Copy Markdown
Contributor

Modified MockMvcHttpConnector to set sameSite using Cookie.getAttribute.

The test relies on MockCookie setting the SameSite attribute to pass.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 1, 2023
@sbrannen sbrannen changed the title Support SameSite attribute in MockMvcHttpConnector Support SameSite cookie attribute in MockMvcHttpConnector Apr 1, 2023
@sbrannen sbrannen self-assigned this Apr 1, 2023
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement status: blocked An issue that's blocked on an external project change labels Apr 1, 2023
@sbrannen
Copy link
Copy Markdown
Member

sbrannen commented Apr 1, 2023

@sbrannen sbrannen added this to the 6.0.8 milestone Apr 1, 2023
@sbrannen sbrannen added in: test Issues in the test module and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 1, 2023
@sbrannen sbrannen removed the status: blocked An issue that's blocked on an external project change label Apr 4, 2023
@sbrannen
Copy link
Copy Markdown
Member

sbrannen commented Apr 4, 2023

FYI: this PR inspired me to create #30285.

So thanks for that. 👍

@sbrannen sbrannen closed this in dd97ee4 Apr 4, 2023
@sbrannen
Copy link
Copy Markdown
Member

sbrannen commented Apr 4, 2023

This has been merged into main.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants