Fixed a deadlock issue that prevented the process from exiting#29692
Closed
uyong wants to merge 1 commit intospring-projects:mainfrom
Closed
Fixed a deadlock issue that prevented the process from exiting#29692uyong wants to merge 1 commit intospring-projects:mainfrom
uyong wants to merge 1 commit intospring-projects:mainfrom
Conversation
Member
|
Thanks for the PR @uyong. Unfortunately, this is not easy to make up our mind based on a one liner change like this. Would you be able to provide a small app that reproduces the behavior you've described? |
Member
|
Closing due to lack of requested feedback. If the feedback is provided we can consider reopening. |
Author
|
@snicoll @sbrannen I'm sorry, but I'm just following this message now; |
Member
Member
Author
|
@snicoll thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
how deadlocks occur?
Fix it:
shutdownHook does not need to acquire a monitor on startupShutdownMonitor , and doClose method is thread safe, it is enough to call it.