You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
having TransactionOperations consuming code switch to non-transactional behavior by injecting NoOpTransactionOperations instead of TransactionTemplate
testing purposes
For first point we have a use case in Spring Session's JdbcOperationsSessionRepository. I've used similar approach in a number of other projects so having Framework provide it OOTB would be nice. Also note that TransactionOperations isn't parameterized, but TransactionOperations#execute is which makes it impossible to have no-op implementation as lambda expression.
Also note that TransactionOperations isn't parameterized, but TransactionOperations#execute is which makes it impossible to have no-op implementation as lambda expression.
Good idea in general! I've implemented this slightly differently as a static withoutTransaction() method on TransactionOperations, along the lines of the recently introduced withDefaults() method on TransactionDefinition.
I don't see anything pushed to the master yet so I'm not sure if I understood the described changes correctly, but if non-transactional behavior is implemented using a new operation on TransactionOperations I'm afraid that won't allow changing transactional behavior by injecting a different TransactionOperations implementation which was the motivation for this PR.
Ideally, TransactionOperations consuming code shouldn't be aware of the fact that there's no transaction involved. This is similar like to, for instance, changing propagation behavior by injecting a differently configured TransactionTemplate.
I'm about to commit this along with a number of other changes now, so it'll be in master in a moment. Thanks for your patience :-)
As for the implementation, withoutTransaction() is a new static factory method on TransactionOperations, returning a TransactionOperations instance with a regular execute method which executes the callback without an actual transaction. This should allow for substitution underneath any TransactionOperations caller as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A no-op implementation can be useful for:
TransactionOperationsconsuming code switch to non-transactional behavior by injectingNoOpTransactionOperationsinstead ofTransactionTemplateFor first point we have a use case in Spring Session's
JdbcOperationsSessionRepository. I've used similar approach in a number of other projects so having Framework provide it OOTB would be nice. Also note thatTransactionOperationsisn't parameterized, butTransactionOperations#executeis which makes it impossible to have no-op implementation as lambda expression.