Fix for ScriptUtils failure when '--' occurs inside a multi-line comment on the same line as '*/'#22392
Merged
jhoeller merged 2 commits intospring-projects:5.1.xfrom Feb 8, 2019
Merged
Conversation
…urs on a line starting with the single-line comment prefix
…comment block where the comment-end delimiter occurs on a line starting with the single-line comment prefix.
|
@mmustaquim Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@mmustaquim Thank you for signing the Contributor License Agreement! |
Contributor
|
Merged and therefore part of 5.1.5 :-) Thanks for the PR! |
Contributor
Author
|
Cool. I didn't expect to move this quickly from issue to submission. Looking forward to the 5.1.5 release. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request against issue #22388