SPR-17606 @Profile mishandles "not" operand mixed with "&"#2066
Merged
jhoeller merged 4 commits intospring-projects:masterfrom Jan 8, 2019
Merged
SPR-17606 @Profile mishandles "not" operand mixed with "&"#2066jhoeller merged 4 commits intospring-projects:masterfrom
jhoeller merged 4 commits intospring-projects:masterfrom
Conversation
Issues: SPR-17606
Issues: SPR-17606
Issues: SPR-17606
Issues: SPR-17606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause of the issue was that single-element inversions (not operator, '!) were greedy and consumed the whole expression prior to inverting it.
This fix provides some contextual information to the parsing method about currently processed element and based on it, returns to previous parsing context.
During the investigation, it turned out that brackets work in similar way (greedy) and some fix was provided as well.