Leverage ObjectProvider instead of autowired containers#1976
Closed
sdeleuze wants to merge 1 commit into
Closed
Conversation
In order to be able to leverage WebFlux configuration in a functional way, WebHttpHandlerBuilder and RouterFunctionMapping should leverage new ObjectProvider capabilities to get a sorted list of beans by type instead of using autowired containers. Issue: SPR-17327
Contributor
Author
|
Merged via 3ff5731. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be able to leverage WebFlux configuration in a functional way,
WebHttpHandlerBuilderandRouterFunctionMappingshould leverage newObjectProvidercapabilities to get a sorted list of beans by type instead of using autowired containers.@bclozel @jhoeller After a second look, it is not required to refactor
DelegatingWebFluxConfigurationsince in functional mode the autowired setter can be called externally usingObjectProvidercapabilities + I don't think we could reach consistent design via a constructor approach.@poutsma Are you ok with these changes?
Issue: SPR-17327