SPR-16663 - Update NamedParameterUtils.parseSqlStatement#1758
Merged
jhoeller merged 1 commit intospring-projects:masterfrom Mar 29, 2018
nkjackzhang:patch-1
Merged
SPR-16663 - Update NamedParameterUtils.parseSqlStatement#1758jhoeller merged 1 commit intospring-projects:masterfrom nkjackzhang:patch-1
jhoeller merged 1 commit intospring-projects:masterfrom
nkjackzhang:patch-1
Conversation
…er correctly
In my opinion, we should parse ":{x}" style parameter as "x" is parameter using "NamedParameterUtils.parseSqlStatement",
so the condition "j - i > 2" is the correct condition, not "j - i > 3", because if "i" is the index of
":" in ":{x}", and "j" is the index of "}" in ":{x}", "j - i == 3" is true.
Also add a test case for SPR-16663.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my opinion, we should parse
:{x}style parameter asxis parameter usingNamedParameterUtils.parseSqlStatement,so the condition
j - i > 2is the correct condition, notj - i > 3, because ifiis the index of:in:{x}, andjis the index of}in:{x},j - i == 3is true.Also add a test case for SPR-16663.