Skip to content

SPR-16340 - Added a new param separator for NamedParameterUtils#1637

Closed
KitHat wants to merge 1 commit intospring-projects:masterfrom
KitHat:master
Closed

SPR-16340 - Added a new param separator for NamedParameterUtils#1637
KitHat wants to merge 1 commit intospring-projects:masterfrom
KitHat:master

Conversation

@KitHat
Copy link

@KitHat KitHat commented Jan 2, 2018

Added '[' and ']' as param separator and test for this case

Closes SPR-16340

Added '[' and ']' as param separator and test for this case

Closes DATAJDBC-159
@KitHat KitHat changed the title Added a new param separator for NamedParameterUtils DATAJDBC-159 - Added a new param separator for NamedParameterUtils Jan 2, 2018
@KitHat KitHat changed the title DATAJDBC-159 - Added a new param separator for NamedParameterUtils SPR-16340 - Added a new param separator for NamedParameterUtils Jan 3, 2018
@snicoll
Copy link
Member

snicoll commented Jan 3, 2018

@KitHat we need a Jira issue in the framework issue tracker to discuss this change. Can you please create one?

@KitHat
Copy link
Author

KitHat commented Jan 3, 2018

@snicoll there is one already https://jira.spring.io/browse/SPR-16340

@snicoll
Copy link
Member

snicoll commented Jan 3, 2018

You referenced DATAJDBC which is not the spring framework's isssue tracker key. I can see now that the issue has been moved.

@jhoeller
Copy link
Contributor

jhoeller commented Jan 9, 2018

Closed in favor of a slightly different implementation (see SPR-16340). Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants