Skip to content

ReadCancellationException does not play well with onErrorContinue #24125

Closed
Closed
ReadCancellationException does not play well with onErrorContinue#24125
Assignees
rstoyanchev
Labels
in: webIssues in web modules (web, webmvc, webflux, websocket)type: bugA general bug
Milestone
5.2.3
@chringwer

Description

@chringwer
chringwer
opened on Dec 3, 2019

The way that ReadCancellationException is used in BodyExtractors is apparently meant to be an implementation detail:

spring-framework/spring-webflux/src/main/java/org/springframework/web/reactive/function/BodyExtractors.java

Lines 269 to 273 in 1bff7ce

.map(buffer -> {
DataBufferUtils.release(buffer);
throw new ReadCancellationException();
})
.onErrorResume(ReadCancellationException.class, ex -> Mono.empty())

However, if somewhere downstream in the pipeline an onErrorContinue operator is appended, the exception does surface which caused me some confusion. Could this be implemented differently without throwing an exception?

Metadata

Metadata

Assignees

Labels

in: webIssues in web modules (web, webmvc, webflux, websocket)type: bugA general bug

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions