Affects: 5.2.0.RELEASE
Inside a @Controller I set the ETag and Cache-control header:
String etag = ...
if (webRequest.checkNotModified( etag ))
return null;
response.setHeader( HttpHeaders.CACHE_CONTROL, CacheControl.maxAge( 30, TimeUnit.DAYS ).cachePublic().getHeaderValue() );ShallowETagHeaderFilter overwrites ETag because isEligibleForEtag method returns true:
String cacheControl = response.getHeader(HttpHeaders.CACHE_CONTROL);
return (cacheControl == null || !cacheControl.contains(DIRECTIVE_NO_STORE));
ShallowEtagHeaderFilter should first check if an ETag is already set and skip it.
Affects: 5.2.0.RELEASE
Inside a
@ControllerI set the ETag and Cache-control header:ShallowETagHeaderFilter overwrites ETag because isEligibleForEtag method returns true:
ShallowEtagHeaderFilter should first check if an ETag is already set and skip it.