Optimize RequestMappingInfo hashcode calculation

rstoyanchev · rstoyanchev · commit a065563484d5 · 2026-02-11T09:42:01.000Z
Precalculated hashcode makes sense for infos in the registry, but matched infos created on the fly don't need it. Closes gh-36279
diff --git a/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java b/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java
@@ -103,7 +103,7 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
 
 	private final RequestConditionHolder customConditionHolder;
 
-	private final int hashCode;
+	private @Nullable Integer hashCode;
 
 	private final BuilderConfiguration options;
 
@@ -162,6 +162,21 @@ private RequestMappingInfo(@Nullable String name,
 			ProducesRequestCondition producesCondition, RequestConditionHolder customCondition,
 			BuilderConfiguration options) {
 
+		this(name, pathPatternsCondition, patternsCondition,
+				methodsCondition, paramsCondition, headersCondition,
+				consumesCondition, producesCondition,
+				customCondition, options, true);
+	}
+
+	private RequestMappingInfo(@Nullable String name,
+			@Nullable PathPatternsRequestCondition pathPatternsCondition,
+			@Nullable PatternsRequestCondition patternsCondition,
+			RequestMethodsRequestCondition methodsCondition, ParamsRequestCondition paramsCondition,
+			HeadersRequestCondition headersCondition, ConsumesRequestCondition consumesCondition,
+			ProducesRequestCondition producesCondition,
+			RequestConditionHolder customCondition, BuilderConfiguration options,
+			boolean calculateHashCode) {
+
 		Assert.isTrue(pathPatternsCondition != null || patternsCondition != null,
 				"Neither PathPatterns nor String patterns condition");
 
@@ -176,10 +191,9 @@ private RequestMappingInfo(@Nullable String name,
 		this.customConditionHolder = customCondition;
 		this.options = options;
 
-		this.hashCode = calculateHashCode(
-				this.pathPatternsCondition, this.patternsCondition,
-				this.methodsCondition, this.paramsCondition, this.headersCondition,
-				this.consumesCondition, this.producesCondition, this.customConditionHolder);
+		if (calculateHashCode) {
+			this.hashCode = calculateHashCode();
+		}
 	}
 
 
@@ -421,7 +435,7 @@ public RequestMappingInfo getMatchingCondition(HttpServletRequest request) {
 			return null;
 		}
 		return new RequestMappingInfo(this.name, pathPatterns, patterns,
-				methods, params, headers, consumes, produces, custom, this.options);
+				methods, params, headers, consumes, produces, custom, this.options, false);
 	}
 
 	/**
@@ -487,19 +501,19 @@ public boolean equals(@Nullable Object other) {
 
 	@Override
 	public int hashCode() {
+		if (this.hashCode == null) {
+			this.hashCode = calculateHashCode();
+		}
 		return this.hashCode;
 	}
 
 	@SuppressWarnings({"ConstantConditions", "NullAway"})
-	private static int calculateHashCode(
-			@Nullable PathPatternsRequestCondition pathPatterns, @Nullable PatternsRequestCondition patterns,
-			RequestMethodsRequestCondition methods, ParamsRequestCondition params, HeadersRequestCondition headers,
-			ConsumesRequestCondition consumes, ProducesRequestCondition produces, RequestConditionHolder custom) {
-
-		return (pathPatterns != null ? pathPatterns : patterns).hashCode() * 31 +
-				methods.hashCode() + params.hashCode() +
-				headers.hashCode() + consumes.hashCode() + produces.hashCode() +
-				custom.hashCode();
+	private int calculateHashCode() {
+		return (this.pathPatternsCondition != null ? this.pathPatternsCondition : this.patternsCondition).hashCode() * 31 +
+				this.methodsCondition.hashCode() +
+				this.paramsCondition.hashCode() + this.headersCondition.hashCode() +
+				this.consumesCondition.hashCode() + this.producesCondition.hashCode() +
+				this.customConditionHolder.hashCode();
 	}
 
 	@Override
