DATAJPA-1406 - Improved alias detection.#291
Closed
schauder wants to merge 2 commits into
Closed
Conversation
There is now a minimal parser combinator library available for internal use. It's used to tokenize SQL statements and then parse the resulting list of tokens. This identifies the primary alias, join aliases, function aliases, and order by claus. The new parser should handle comments, character literals, quoted identifiers and subselects correctly. It also should be easier to extend and to adapt to further requirements.
02d742b to
060324c
Compare
Contributor
Author
|
In a team discussion we decided not get into full blown parsing of SQL and JPQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is now a minimal parser combinator library available for internal use.
It's used to tokenize SQL statements and then parse the resulting list of tokens.
This identifies the primary alias, join aliases, function aliases, and order by clause.
The new parser should handle comments, character literals, quoted identifiers and subselects correctly.
It also should be easier to extend and to adapt to further requirements.