Skip to content

MDC trace and span IDs for Brave and OTel#32488

Closed
marcingrzejszczak wants to merge 1 commit intospring-projects:mainfrom
marcingrzejszczak:mdcForTracing
Closed

MDC trace and span IDs for Brave and OTel#32488
marcingrzejszczak wants to merge 1 commit intospring-projects:mainfrom
marcingrzejszczak:mdcForTracing

Conversation

@marcingrzejszczak
Copy link
Copy Markdown
Contributor

@marcingrzejszczak marcingrzejszczak commented Sep 23, 2022 •
edited
Loading

Conditionals

  • If Micrometer Tracing IS on the classpath
    • For Brave
      • [MDC] If MDC is on the classpath
        • We will setup injecting spanId / traceId to MDC context
    • For OTel:
      • [MDC] If MDC is on the classpath
        • We will setup injecting spanId / traceId to MDC context

superseeds #32214
split from #32480

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 23, 2022
@marcingrzejszczak marcingrzejszczak mentioned this pull request Sep 23, 2022
Closed
2 tasks
@wilkinsona
Copy link
Copy Markdown
Member

wilkinsona commented Sep 27, 2022

I got confused by the separation of the 3 PRs and processed this all in #32480 in the end. Sorry.

@wilkinsona wilkinsona closed this Sep 27, 2022
@wilkinsona wilkinsona added status: superseded An issue that has been superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: superseded An issue that has been superseded by another

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcingrzejszczak @wilkinsona @spring-projects-issues