Fix message ordering in MongoChatMemoryRepository#5339
Closed
chanani wants to merge 2 commits intospring-projects:mainfrom
Closed
Fix message ordering in MongoChatMemoryRepository#5339chanani wants to merge 2 commits intospring-projects:mainfrom
chanani wants to merge 2 commits intospring-projects:mainfrom
Conversation
Changed sort order from descending to ascending in findByConversationId() to maintain chronological conversation flow. Fixes spring-projects#5330 Signed-off-by: CHANHAN <130114269+chanani@users.noreply.github.com>
tinomthomas
reviewed
Jan 27, 2026
tinomthomas
left a comment
There was a problem hiding this comment.
@chanani Can you please add/update a test case also to cover this?
Added messagesAreReturnedInChronologicalOrder test to verify that messages are returned in the same order they were saved. Signed-off-by: CHANHAN <130114269+chanani@users.noreply.github.com>
Contributor
Author
|
@tinomthomas, Added test case The test validates that messages are returned in the same order they were saved, ensuring the fix maintains proper conversation flow. Let me know if you need any changes ! |
Member
|
@chanani Thanks for the fix! |
Contributor
|
@ilayaperumalg LGTM, except the javaformat. Do we have a way to mark this change in release notes as it may break someones behaviour? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed message ordering bug where
MongoChatMemoryRepository.findByConversationId()returned messages in reverse chronological order, causing incorrect conversation flow for LLMs.Changes
descending()toascending()infindByConversationId()Why
Before (Bug):
After (Fixed):
This aligns with
PostgresChatMemoryRepositoryDialect:Testing
findByConversationId()validates message order withassertThat(results).isEqualTo(messages)CIwill validateFixes #5330