This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Refactor ReactiveMongoWebSessionConfiguration#19
Closed
vpavic wants to merge 1 commit intospring-attic:masterfrom
vpavic:fix-reactive-config
Closed
Refactor ReactiveMongoWebSessionConfiguration#19vpavic wants to merge 1 commit intospring-attic:masterfrom vpavic:fix-reactive-config
ReactiveMongoWebSessionConfiguration#19vpavic wants to merge 1 commit intospring-attic:masterfrom
vpavic:fix-reactive-config
Conversation
This commit updates `ReactiveMongoWebSessionConfiguration` to extend `SpringWebSessionConfiguration` rather than having it imported via `@EnableMongoWebSession`. This is required in order for Spring Boot auto-configuration to work properly.
This was referenced Nov 16, 2017
Contributor
|
I'll merge and polish it this afternoon. |
Contributor
|
Resolved via e8d12b5. Thanks! |
Contributor
Author
|
Thanks for merging this Greg - any chance you do a quick RC2? There are two Boot issues/PRs blocked on this (spring-projects/spring-boot#11055 and spring-projects/spring-boot#11063) so it would be nice if we could get those in early? Note that the Spring Session GA is scheduled for Nov 27th ATM. |
Contributor
|
Boot M7 is scheduled for the 28th. Is it not sufficient to wait for Session's GA scheduled on the 27th? (I was planning to have ours GA on the same date) cc @rwinch |
Contributor
Author
|
Yes, I guess that's an option now that Boot has been delayed. Session's GA was originally scheduled after Boot's M7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
ReactiveMongoWebSessionConfigurationto extendSpringWebSessionConfigurationrather than having it imported via@EnableMongoWebSession.This is required in order for Spring Boot auto-configuration to work properly since it extends the
ReactiveMongoWebSessionConfiguration. The same approach is used in theMongoHttpSessionConfigurationand all configuration classes inspring-sessionproject.