Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

feat: cleanup task executions older than x days#1940

Merged
oodamien merged 15 commits intospring-attic:mainfrom
klopfdreh:feature/cleanupendtime
Sep 6, 2023
Merged

feat: cleanup task executions older than x days#1940
oodamien merged 15 commits intospring-attic:mainfrom
klopfdreh:feature/cleanupendtime

Conversation

@klopfdreh
Copy link
Contributor

@klopfdreh klopfdreh commented Aug 2, 2023

Needs to be integrated with: spring-attic/spring-cloud-dataflow#5422

Bildschirmfoto 2023-08-02 um 11 06 42

You can enter a number of days and if the task executions are older than before 5 days for example they are removed.

See #1949

@oodamien
Copy link
Contributor

oodamien commented Aug 4, 2023

Hi @klopfdreh,
The use case is interesting.
We have to work a bit more on the UX/UI.

@klopfdreh
Copy link
Contributor Author

Hey @oodamien - no problem, the backend implementation is working for us and also fixes a bug with boot 3 / batch 5. The underscore is misaligned with the link so it would be great to see how you would implement it. 👍

@onobc
Copy link
Contributor

onobc commented Sep 1, 2023

Just for a status update on the backend... we are very close to getting it merged into SCDF main.

@oodamien
Copy link
Contributor

oodamien commented Sep 1, 2023

Update: Working on the UI/UX, I should push changes soon on this PR.

@klopfdreh
Copy link
Contributor Author

Thanks for the update and for your work - I am very interested in how you changed the UI implementation @oodamien

@onobc
Copy link
Contributor

onobc commented Sep 4, 2023

The backend changes have been merged in spring-attic/spring-cloud-dataflow@af60a25

@klopfdreh
Copy link
Contributor Author

For the changes:

"taskJob": "Task/Job Executions"
"taskJob": "Aufgaben-Ausführung"
"taskJob": "выполнение задач/заданий"

"content": "You can filters the task/job execution(s) you want to clean up:"
"content": "Sie können die Task-/Job-Ausführungen filtern, die Sie aufräumen wollen:"
"content": "Вы можете отфильтровать выполнение задач/заданий, которые хотите очистить:"

"onlyComplete": "Only complete execution(s)"
"onlyComplete": "Nur beendete Ausführung(en)"
"onlyComplete": "Только полное выполнение(я)"

"olderExecution": "Cleanup older execution(s)"
"olderExecution": "Aufräumen älterer Ausführung(en)"
"olderExecution": "Очистка старых исполнений"

"days": "Days"
"days": "Tage"
"days": "Дни"

"daysInvalid": "Invalid days"
"daysInvalid": "Tage ungültig"
"daysInvalid": "Неверные дни"

"successContent": "Execution(s) cleaned up."
"successContent": "Ausführung(en) erfolgreich aufgeräumt."
"successContent": "Исполнение(я) очищено."

German is valid 😄 - Russian should be checked.

The CSS tools.component.css can be removed as the markup is not used anymore.

@klopfdreh
Copy link
Contributor Author

Can you provide a screenshot so that I can see the appearance, now? 😃

I am currently busy by solving some issues at work, so I don’t know when I am able to check it out and test.

@oodamien
Copy link
Contributor

oodamien commented Sep 5, 2023

Sure :

image image image

@onobc
Copy link
Contributor

onobc commented Sep 5, 2023

Looks good @oodamien ,

One thing to point out is that "Only complete execution(s)" does not make sense when "Cleanup older execution(s)" as the "end_date" is used as the date anchor. IOW - the executions must be completed in order to determine how many days old they are.

@oodamien
Copy link
Contributor

oodamien commented Sep 5, 2023

I see. Let's make the "Cleanup older execution(s)" visible only if complete is checked.

image image image

@klopfdreh
Copy link
Contributor Author

Awesome! 👍

Copy link
Contributor

@claudiahub claudiahub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, about Russian translations I've double checked on en to tu translators

@oodamien oodamien merged commit 85df243 into spring-attic:main Sep 6, 2023
@oodamien
Copy link
Contributor

oodamien commented Sep 6, 2023

Thanks @klopfdreh

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants