This repository was archived by the owner on May 14, 2025. It is now read-only.
Update documentation for initContainers addition in spring-cloud-deployer#5866
Closed
corneil wants to merge 2 commits intospring-attic:mainfrom
Closed
Update documentation for initContainers addition in spring-cloud-deployer#5866corneil wants to merge 2 commits intospring-attic:mainfrom
corneil wants to merge 2 commits intospring-attic:mainfrom
Conversation
cppwfs
suggested changes
Aug 7, 2024
| ---- | ||
| deployer.<application>.kubernetes.initContainer={containerName: 'test', imageName: 'busybox:latest', commands: ['sh', '-c', 'echo hello']} | ||
| # alternative for multiple init containers | ||
| deployer.<application>.kubernetes.initContainers=[{containerName:'test',imageName:'busybox:latest',commands:['sh','-c','echo hello']},{containerName:'test2',imageName:'busybox:latest',commands:['sh','-c','echo world']}] |
Contributor
There was a problem hiding this comment.
Nitpick : Make sure we have a space after the comma so samples line up with each other.
Contributor
There was a problem hiding this comment.
Should the alternative example go below the multiple containers example?
Contributor
There was a problem hiding this comment.
inidividually is misspelled ;-)
| @@ -1134,6 +1134,11 @@ The following example shows how you can configure an Init Container for an appli | |||
| [source,options=nowrap] | |||
Contributor
There was a problem hiding this comment.
Should line 1131 be updated to say "The following example shows how you can configure an Init Container or containers for an application:"?
c0462f2 to
f0fb797
Compare
cppwfs
approved these changes
Aug 23, 2024
Contributor
cppwfs
left a comment
There was a problem hiding this comment.
I'll fix the , issue when I merge.
Contributor
|
LGTM Squashed Merged |
Contributor
|
forward ported to main-3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to spring-attic/spring-cloud-deployer#465