This repository was archived by the owner on May 14, 2025. It is now read-only.
last task execution performance#5843
Merged
corneil merged 2 commits intospring-attic:mainfrom Jun 26, 2024
Merged
Conversation
added 2 commits
June 13, 2024 16:39
cppwfs
approved these changes
Jun 13, 2024
Contributor
cppwfs
left a comment
There was a problem hiding this comment.
LGTM
Kicked the tires on this PR. I loaded up a DB with enough data so that I could measure the net improvement. I saw about a 25% improvement.
When merged can you either move the tests you reactivated to main-3 or create a trello ticket to tell me to do it :-)
Contributor
Author
How many definitions did you have? It has an exponential impact with more definitions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full list was retrieved for each task instead of queries by schema.
Also found test that weren't executed and changed
@Nestedtostaticclasses.